.NET: Update to .NET 10 SDK #2267
Conversation
Youssef1313
temporarily deployed
to
integration
GitHub Actions
Inactive
Youssef1313
temporarily deployed
to
integration
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to update the .NET SDK from version 9.0 to 10.0 by modifying the GitHub workflow configuration. However, the update is incomplete as it only changes the dotnet-format.yml workflow file while leaving other workflow files, project files, and build configuration files still targeting .NET 9.0.
Key changes:
- Updates the .NET SDK version in the
dotnet-format.ymlworkflow from "9.0" to "10.0"
|
We already have a PR for .NET10 update: #2128 |
|
@DeagleGross Yup, I had a chat with @rogerbarreto about it. The other PR does much more than updating .NET SDK though and I don't know when it will be finalized. So this PR is a subset of the other. If the other PR got merged first, this one can be closed. |
|
This PR does not achieve the target goal (I guess) which is having NuGet packages published with the .NET 10 target. agent-framework/dotnet/Directory.Build.props Lines 13 to 15 in 57ca139 We should focus on taking Stephen's PR I've mentioned (#2128), because it does update all the packages, updates LangVersion, cleanups ifdefs and does many more other useful stuff, which should come all together IMO. Maybe I am wrong, so not blocking the PR anyway |
|
I agree with @DeagleGross, I think we should go with #2128 |
|
We should be able to merge #2128 once a build for Ignite is complete, if that hasn't happened already. |
crickman
left a comment
crickman
left a comment
There was a problem hiding this comment.
@Youssef1313 - @stephentoub is driving a comprehensive update that addresses this. I wonder if you'd be able to review and comment on this change: #2128
7 participants
Motivation and Context
Description
Contribution Checklist